[Webkit-unassigned] [Bug 31049] Watch expression editor should stay open after Add button was clicked

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 3 09:10:35 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31049


Patrick Mueller <pmuellr at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42387|                            |review?
               Flag|                            |




--- Comment #4 from Patrick Mueller <pmuellr at yahoo.com>  2009-11-03 09:10:34 PDT ---
Created an attachment (id=42387)
 --> (https://bugs.webkit.org/attachment.cgi?id=42387)
proposed patch 2009/11/03 - a

Moved the code to put the entry into "edit" mode into the path where the entry
is added to the tree.  With the new async eval(), the old code path would never
work, because the entry wasn't added by the time the code was run.  

Because the new check for "edit" mode is now in a code path that runs a lot
more often, also added a flag - _newExpressionAdded - to indicate when the
check should be made, since it requires a linear search through the watch
expressions, and could in theory be expensive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list