[Webkit-unassigned] [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30623


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42364|review?                     |review-
               Flag|                            |




--- Comment #4 from Xan Lopez <xan.lopez at gmail.com>  2009-11-03 03:08:40 PDT ---
(From update of attachment 42364)
This looks good to me, seems to fit nicely as a first step on the overall plan
and is a good improvement by itself (IMHO) since it allows the views to share
the same targelist.

I just have a couple of nitpick style comments:

targetlist in here:

+private:
+    GtkTargetList* targetList;

should be m_targetList, per style guide.

Also, I'm in doubt about the name for 'fullTargetList'. I see that in future
patches you'll add new methods to get the targetlist for DataObject and
GdkDragContext, but I wonder if you really need to add 'full' to the
parameter-less method to avoid confusions.

Other than that, looks good to me. Marking r- at least for the style issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.