[Webkit-unassigned] [Bug 31040] New: Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31040

           Summary: Use explicit parentheses to silence gcc 4.4
                    -Wparentheses warnings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: laszlo.1.gombos at nokia.com


GCC 4.4 -Wparentheses now warns about expressions such as (!x | y) and (!x &
y). Using explicit parentheses, such as in ((!x) | y), silences this warning --
see the release notes: http://gcc.gnu.org/gcc-4.4/changes.html

As an example QtWebKit buildbot is using GCC 4.4 here are some of the warnings:

JavaScriptCore/interpreter/Interpreter.cpp:1491: warning: suggest parentheses
around arithmetic in operand of |
JavaScriptCore/interpreter/Interpreter.cpp:1578: warning: suggest parentheses
around arithmetic in operand of |
WebCore/editing/TextIterator.cpp:221: warning: suggest parentheses around &&
within ||
WebCore/editing/VisibleSelection.cpp:240: warning: suggest parentheses around
&& within ||
WebCore/html/HTMLLinkElement.cpp:191: warning: suggest parentheses around &&
within ||
WebCore/loader/RedirectScheduler.cpp:174: warning: suggest parentheses around
&& within ||
WebCore/rendering/RenderBlock.cpp:956: warning: suggest parentheses around &&
within ||
WebCore/rendering/RenderBox.cpp:1474: warning: suggest parentheses around &&
within ||
WebCore/rendering/RenderTextControlMultiLine.cpp:68: warning: suggest
parentheses around && within ||
WebCore/rendering/style/RenderStyle.cpp:458: warning: suggest parentheses
around && within ||
WebCore/platform/graphics/qt/FontCacheQt.cpp:126: warning: suggest parentheses
around + or - inside shift
WebCore/platform/graphics/qt/FontCacheQt.cpp:127: warning: suggest parentheses
around + or - inside shift
WebCore/platform/graphics/qt/FontCacheQt.cpp:128: warning: suggest parentheses
around + or - inside shift
WebKit/qt/Api/qwebpage.cpp:1213: warning: suggest parentheses around && within
||
WebKit/qt/Api/qwebpage.cpp:1219: warning: suggest parentheses around && within
||
WebKit/qt/Api/qwebpage.cpp:1223: warning: suggest parentheses around && within
||
WebCore/svg/SVGAnimateElement.cpp:67: warning: suggest parentheses around &&
within ||
WebCore/svg/SVGAnimationElement.cpp:492: warning: suggest parentheses around &&
within ||
WebCore/svg/SVGPreserveAspectRatio.cpp:183: warning: suggest parentheses around
&& within ||
WebCore/loader/appcache/ApplicationCacheGroup.cpp:625: warning: suggest
parentheses around && within ||
WebCore/dom/Document.cpp:2494: warning: suggest parentheses around && within ||

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.