[Webkit-unassigned] [Bug 30979] [Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30979


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.poulain at nokia.com




--- Comment #7 from Benjamin Poulain <benjamin.poulain at nokia.com>  2009-11-02 17:25:43 PDT ---
Instead of 
+#if defined(Q_WS_X11)
+#include <QX11Info>
+#endif

+int QWebPageWidgetClient::screenNumber() const
+{
+#if defined(Q_WS_X11)
+    if (view)
+        return view->x11Info().screen();
+#endif
+
+    return 0;
+}

Could use QDesktopWidget::screenNumber() which is cross-platform?

Simon also suggest to recycle the client instead of throwing it all the time:
+        delete d->client;
+        d->client = view ? new QWebPageWidgetClient(view) : 0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.