[Webkit-unassigned] [Bug 27491] Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27491


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41845|review?                     |review-
               Flag|                            |




--- Comment #20 from David Levin <levin at chromium.org>  2009-11-02 11:39:45 PDT ---
(From update of attachment 41845)
Just one issue.

> diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests
> @@ -604,6 +603,32 @@ for my $test (@tests) {
>              }
>              print OUT "$testPath$suffixExpectedHash\n";
>          }
> +    } elsif ($test =~ /^websocket\//) {
> +        openWebSocketServerIfNeeded();

It seems like this should be in the "else" below because some of these test may
run without needing the web socket server started.

> +        if ($test =~ /^websocket\/tests\/local\//) {
> +            my $testPath = "$testDirectory/$test";
> +            if (isCygwin()) {
> +                $testPath = toWindowsPath($testPath);
> +            } else {
> +                $testPath = canonpath($testPath);
> +            }
> +            print OUT "$testPath\n";
> +        } else {
> +            my $path = canonpath($test);
> +            if ($test =~ /^websocket\/tests\/ssl\//) {
> +                print OUT "https://127.0.0.1:$webSocketSecurePort/$path\n";
> +            } else {
> +                print OUT "http://127.0.0.1:$webSocketPort/$path\n";
> +            }
> +        }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.