[Webkit-unassigned] [Bug 30997] [Gtk] Implement AtkDocument's attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30997





--- Comment #10 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-02 10:00:23 PDT ---
(In reply to comment #9)
> Joanmarie, 

Friends, colleagues, and a11y folks call me Joanie. :-)

> It sounds like you are doing things correctly. You need to test the GTK
> wrapper, so it sounds correct that you should Skip the test for Win/mac and
> also stub out the DRT methods for those platforms

Yup, these things I understand. What I'm hung up on, and I readily admit that
:-), is the fundamental purpose behind the layout tests versus that of the unit
tests, and why what I want here is a layout test and not a unit test.

> However, I think it would be nice if you could put the document attribute
> getting stuff into AccessibilityObject, so that if Mac/Win needed to implement
> similar things in the future, they wouldn't have to duplicate the functionality

I'd be happy to do so.

> that way, your wrapper just needs to call one method on the AX object to get
> the right info.

Well.... If it goes into the cross-platform code, I'm tempted to make it three
methods (1 for Encoding, 1 for URI, and 1 for DocType). Who's to say what
constitutes *the* document attributes? Or do you feel it really should be one?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.