[Webkit-unassigned] [Bug 30998] [Gtk] Implement AtkDocument's locale support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30998





--- Comment #2 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-02 03:37:17 PDT ---
(In reply to comment #1)
> (From update of attachment 42281 [details])
> >  static const gchar* webkit_accessible_document_get_locale(AtkDocument* document)
> >  {
> > -    // FIXME: This needs to be implemented.
> > -    notImplemented();
> > +
> > +    // TODO: Should we fall back on lang xml:lang when the following comes up empty?
> > +    String language = static_cast<AccessibilityRenderObject*>(core(document))->language();
> > +    if (!language.isEmpty())
> > +        return returnString(language);
> 
> Should this return NULL if empty?

I think so. Do you think otherwise? Or am I missing something?

-    // FIXME: This needs to be implemented.
-    notImplemented();
+
+    // TODO: Should we fall back on lang xml:lang when the following comes up
empty?
+    String language =
static_cast<AccessibilityRenderObject*>(core(document))->language();
+    if (!language.isEmpty())
+        return returnString(language);
+
     return 0;
     ^^^^^^^^^

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.