[Webkit-unassigned] [Bug 30773] [Qt] QWebInspector: improve QWebPage::webInspectorTriggered(QWebElement&) -> QWebInspector::show() connection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30773





--- Comment #7 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2009-11-02 03:14:22 PDT ---
(In reply to comment #6)
> It is possible to use the same web inspector for more pages?
> 
> I don't like the set page so much, as it is more a "watch page" or so. Would it
> be possible to do it the other way around?
> 
> QWebPage::setInspectable(new QWebInspector) ?

The relation is 1<->1, so if you assign the same inspector to a different page,
the previous page is unassociated (explained to the user in the documentation).

A reason I like the "set" is because it suggests that the objects are bound
together. We first called it setInspectedPage, but since the web inspector
implicitly inspects pages, so we omitted the "inspected". Maybe we should
re-add inspected or watched to the method just in case we want the
QWebInspector to have different interractions with a QWebPage? (what would that
be?)

The method is in the inspector class to make it feel similar to
QWebView::setPage, they are both UI layer objects that interact with the web
page which feels more like a "content" layer object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.