[Webkit-unassigned] [Bug 20780] when choosing an auto-completed value in a text input field the javascript 'change' event is not fired.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20780


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |micdesim at gmail.com




--- Comment #19 from Daniel Bates <dbates at webkit.org>  2009-11-01 18:29:39 PDT ---
I think it would probably be best if this function was removed in a separate
bug. Let me know if you think we should remove this function in this patch.

For your reference:

RenderTextControl::setUserEdited was first added in r24652
<http://trac.webkit.org/changeset/24652> as part of the patch for bug
<rdar://problem/5359921> (I don't know what the issue was other than what is
implied from the change log comment, since I don't have rdar access).

Then in r34626 <http://trac.webkit.org/changeset/34626>,
RenderTextControl::setUserEdited was changed to include the the line
"document()->setIgnoreAutofocus(isUserEdited)" as part of the patch for bug
#18887.

The following test cases were added mentioned in the change log for bug #18887:
fast/forms/autofocus-attribute.html
fast/forms/autofocus-opera-001.html
fast/forms/autofocus-opera-002.html
fast/forms/autofocus-opera-003.html
fast/forms/autofocus-opera-004.html
fast/forms/autofocus-opera-005.html
fast/forms/autofocus-opera-006.html
fast/forms/autofocus-opera-007.html
fast/forms/autofocus-opera-008.html

CC'ing Michelangelo De Simone, as he may have some insight into r34626,
including the change to RenderTextControl::setUserEdited and the autofocus
code.

(In reply to comment #18)
> (In reply to comment #16)
> > (*) Notice, RenderTextControl::setUserEdited sets m_userEdited AND calls
> > Document::setIgnoreAutofocus.
> 
> Since nobody calls it, that doesn’t matter. We should go back and find the
> change where someone modified the setUserEdited function and see if there’s a
> test case that should be failing. It seems like the autofocus work was done
> incorrectly since modifying a function that nobody calls clearly can’t have an
> effect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.