[Webkit-unassigned] [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29972


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42285|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2009-11-01 17:18:53 PDT ---
(From update of attachment 42285)
>  bool protocolIs(const String& url, const char* protocol);
>  bool protocolIsJavaScript(const String& url);
> +bool protocolIsValid(const String& protocol);

Sorry I didn’t realize this in earlier patch rounds. The other functions here
work on URLs and check various aspects of the protocol. This new one works on a
protocol.

I think it should be named isValidProtocol instead of protocolIsValid, to make
this slightly clearer. This name change can happen in a separate patch.

I didn’t look too closely at anything else in this patch -- a cursory look
seems to indicate it’s right, so r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.