[Webkit-unassigned] [Bug 30964] [Gtk] Implement AtkDocument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 1 13:57:36 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=30964





--- Comment #16 from Eric Seidel <eric at webkit.org>  2009-11-01 13:57:35 PDT ---
(In reply to comment #15)
> (In reply to comment #10)
> > bugzilla-tool is not smart enough to leave bugs open after landing due to bug
> > 28230.  So this bug will need to be re-opened after the commit-queue lands
> > patch #1.  Either someone (which can be me), needs to fix bug 28230, or better
> > yet, we should follow the one-change-per-bug style that is more common in
> > WebKit. :)
> 
> Sorry. New bugs spun off for each patch.
> 
> Should I also file new bugs for the tests which I will (hopefully) write for
> each of those bugs, or do tests associated with a fix constitute part of a
> single change?

Certainly nothing to apologize for!  :)   I just wanted you to know that our
tools don't handle multiple-patches-per-bug very well.

Tests should go along with fixes.  When I review patches often seeing and
understanding what the tests are doing is more important than the code itself. 
If we have a test, we'll never break the code in the same way again. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list