[Webkit-unassigned] [Bug 30979] [Qt] Expose QWebPageClient through the QtWebKit API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30979





--- Comment #3 from Yael <yael.aharon at nokia.com>  2009-11-01 13:45:47 PDT ---
(In reply to comment #2)
> We introduced QWebPageClient to decouple WebCore from the widgets or graphics
> items in the WebKit layer on top. It is designed as private interface, it is
> not designed to be part of the public API. 
I am more than happy to discuss an alternative solution, that will not involve
exposing QWebPageClient.

> Making it public means we cannot
> change it anymore, we wouldn't be able to add new virtual functions or rename
> existing ones.
The modified QWebPageClient is inheriting QObject. We will not be able to add
new virtual methods, but we will be able to add new signals and slots instead.

> We should extend the existing public API (QWebPage, QWebView, QGraphicsWebView)
> instead of introducing yet another public interface for developers to learn.
Qt 4.5 allows replacing QWebView with another QWidget, and there are no side
effects. In Qt 4.6, applications that replace QWebView with their own QWidget
will crash when loading plugins. IMO, this is regression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.