[Webkit-unassigned] [Bug 25562] Potential crash after ApplicationCacheStorage::storeNewestCache() fails.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 29 09:56:12 PDT 2009


ap at webkit.org changed:

           What    |Removed                     |Added
  Attachment #30702|review?                     |review-
               Flag|                            |

------- Comment #11 from ap at webkit.org  2009-05-29 09:56 PDT -------
(From update of attachment 30702)
Discussed this on IRC in some depth. I have two technical concerns about this
1) Since failing ApplicationCacheStorage::store() leaves memory objects with
hanging StorageIDs, it's hard to prove that this broken invariant doesn't cause
problems later on.
2) There is a good deal of confusion about m_pendingMasterResourceLoaders and
"pending master entries", e.g. in comments about NewDocumentLoader. The names
New/OldDocumentLoader names are not good, which I think is a sign of using data
structures that don't match the logic well.

I'm really holding you up to a somewhat higher bar than customary, sorry for
being so picky. That's because appcache code is rather complicated, and because
this doesn't have automated testing to guarantee sustained progress in future
patches. So, we'd better get it right on the first try.

More globally, it doesn't seem obvious at all that reinstating the old cache is
indeed the best behavior. We already have a fully downloaded up to date
application in memory, why not use it? Looks like the spec should talk about
out of quota situations.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list