[Webkit-unassigned] [Bug 25972] Help Disambiguate min/max calls in TimeRanges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25972


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30755|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2009-05-29 07:53 PDT -------
(From update of attachment 30755)
This is close to correct, but not quite.

Since this is a header, it's not appropriate to say "using namespace std" here.
We need to remove that. Adding the include of <algorithm> is also good, but it
needs to be sorted in with the rest of the includes, not a separate paragraph.
And we do indeed need to add the "std::" prefixes.

Further, SMILTime.h should not define min and max functions, since the std
versions will work fine on SMILTime objects.

review- because I'd prefer to see a patch that removes the incorrect "using
namespace std".


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.