[Webkit-unassigned] [Bug 26001] Change callers of String::adopt() to String::createUninitialized()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26001


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30737|review?                     |review+
               Flag|                            |




------- Comment #7 from darin at apple.com  2009-05-28 09:18 PDT -------
(From update of attachment 30737)
> +        if (c->nodeType() == Node::TEXT_NODE || c->nodeType() == Node::CDATA_SECTION_NODE || c->nodeType() == Node::COMMENT_NODE) {

Since nodeType() is a virtual function, it's too bad we're calling it three
times on each non-textual node.

> +            int nodeLength = nodeValue.length();

Should be unsigned, not int.

> +        int dataLength = data.length();

Should be unsigned, not int.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.