[Webkit-unassigned] [Bug 26041] Allow adding resource source to frame asynchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26041





------- Comment #7 from yurys at chromium.org  2009-05-28 03:37 PDT -------
(In reply to comment #6)
> (From update of attachment 30732 [review])
> Seems odd addSourceToFrame returns a bool and addResourceSourceToFrame does
> not. Can addResourceSourceToFrame still return a bool? If the resource isn't
> found retuen false and retuen the result of addSourceToFrame.
> 
addSourceToFrame always work sinchronously because all data it may need are
passed in the arguments while addResourceSourceToFrame in case of Chrome may
need to request script source for given identifier from the inspected process.
Until response is received we cannot tell whether the source adding succeeded
or not. That is the reason why addResourceSourceToFrame doesn't return 'bool'
anymore. Instead if the source is added successfuly the iframe will generate
'load' event.



> +        delete this._frameNeedsSetup;
> 
> You shouldn't need this sine _frameNeedsSetup was deleted in
> setupSourceFrameIfNeeded.
> 
In the asynchronous case the following scenario is possible:
- setupSourceFrameIfNeeded calls addResourceSourceToFrame which sends request
for the source and returns
- _resourceLoadingFinished is called and sets this._frameNeedsSetup to true
- response to the source request is received, content is loaded and
_frameNeedsSetup is not cleared which causes one extra frame loading in the
next call to setupSourceFrameIfNeeded


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.