[Webkit-unassigned] [Bug 25972] Help Disambiguate min/max calls in TimeRanges

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25972





------- Comment #4 from bfulgham at webkit.org  2009-05-27 09:05 PDT -------
Building the Windows Cairo target, the min/max calls in TimeRanges.h are
misinterpreted, leading to a compile-time error:
c:\Cygwin\home\bfulgham\WebKit\WebCore\html\TimeRanges.h(93) : error C2440: '='
: cannot convert from 'WebCore::SMILTime' to 'float'
        No user-defined-conversion operator available that can perform this
conversion, or the operator cannot be called
c:\Cygwin\home\bfulgham\WebKit\WebCore\html\TimeRanges.h(94) : error C2440: '='
: cannot convert from 'WebCore::SMILTime' to 'float'
        No user-defined-conversion operator available that can perform this
conversion, or the operator cannot be called

Somehow, it seems to be confused about the correct signature for min/max,
resolving to the animation/SMILTime data type:
     inline SMILTime max(const SMILTime& a, const SMILTime& b) { return
std::max(a.value(), b.value()); }
     inline SMILTime min(const SMILTime& a, const SMILTime& b) { return
std::min(a.value(), b.value()); }

Modifying the TimeRanges implementation to explicitly use the std::min/std::max
calls resolves the compile error.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.