[Webkit-unassigned] [Bug 25911] Apply href in base elements to anchors shown on the source viewer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 23:39:14 PDT 2009


------- Comment #11 from tyoshino at google.com  2009-05-26 23:39 PDT -------
(In reply to comment #9)
> (From update of attachment 30644 [review])
> > +                            if (token->tagName == baseTag && equalIgnoringCase(attr->name().localName(), "href")) {
> I'm not sure why the code in this class checks attribute names in this
> inefficient way. In normal WebCore code we would just compare with hrefAttr
> using == instead.
> r=me

Thank you. After your comment, I investigated and understood the reason. In
order to show HTML sources as is on the view-source window, HTMLTokenizer
doesn't lower names when inViewSourceMode() is true. So, we have to lower names
before comparison in HTMLViewSourceDocument class. Patch revision 2 was
comparing tagName and baseTag case sensitively, so I updated to revision 3.
Please take a look again.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list