[Webkit-unassigned] [Bug 25899] PC Chromium: keyboard selection in Hebrew select element doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25899





------- Comment #6 from xji at chromium.org  2009-05-26 14:26 PDT -------
(In reply to comment #5)
> The selection is exposed via select.value no?  You can input key events
> directly to the element using eventSender.
> 
> Something like this:
> 
> <select id="mySelect>...
> 
> <script>
> mySelect.focus()
> eventSender.key... 
> assert(mySelect.value == "some string I wanted it to search for");
> </scirpt>
> 

Tony has a patch in which he explained why PopupMenuChromium.cpp is not
testable.
His patch is:
https://bugs.webkit.org/attachment.cgi?id=30676

The comments are:
+        Not testable since it involves sending a keyboard event to
+        the popup, which is not possible (eventSender sends the key
+        events through webview, we want to go through the webwidget).


But I think my patch should be:
- m_lastCharTime = now;
+ #if PLATFORM(WIN_OS)
+     if (event.type() == PlatformKeyboardEvent::Char) 
+         m_lastCharTime = now;
+ #else
+     if (event.type() == PlatformKeyboardEvent::KeyDown) 
+         m_lastCharTime = now;
+ #endif

I will test in Mac and upload the patch again.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.