[Webkit-unassigned] [Bug 25551] Support for HTML5 Forms "required" attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25551





------- Comment #2 from pkasting at google.com  2009-05-26 14:21 PDT -------
I'm not a reviewer, but here are my drive-by comments.

* Lines should not have only whitespace in them (some added lines have spaces
in them).  Use a linter.

* I wouldn't bother with FIXMEs and TODOs for "add support for more input
types" in these functions as whenever more input types are added it will be
clear they need to be handled everywhere the existing types are.  Since we
don't yet have the enum values for these this just decreases clarity.

* "Leads us to understand whether or not a form control could potentially be a
required form control." is incredibly verbose and vague at the same time. 
Either don't comment or say something like "True if this control supports the
'required' attribute for form validation."

* Add tests (as you noted).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.