[Webkit-unassigned] [Bug 23477] Support for WCSS extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23477





------- Comment #22 from hyatt at apple.com  2009-05-26 13:15 PDT -------
(From update of attachment 28750)
Seems like you are missing checking for m_wapInput in the == operator of
StyleRareNonInheritedData.

I see code that is asking if isTextField() || isPasswordField().  Isn't it
impossible to be a password field and not be a text field?  Seems like you just
need to check isTextField?

I don't much like the name WebTextFormatMask. What's the reasoning behind
prefacing the name with "Web"?  Seems like you could just drop that.

You should use an OwnPtr for m_textFormatMask.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.