[Webkit-unassigned] [Bug 26001] Change callers of String::adopt() to String::createUninitialized()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26001


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30660|review?                     |review+
               Flag|                            |




------- Comment #5 from darin at apple.com  2009-05-26 09:12 PDT -------
(From update of attachment 30660)
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 44135)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,31 @@
> +2009-05-25  David Moore  <davemoore at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).

There's no comment here. Need to cite the bug number and URL and say what
you're doing and why. Event better is to have a per-function comment explaining
what was done to each function.

> +        int dataLength = data.length();

Should be unsigned.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.