[Webkit-unassigned] [Bug 25072] CSS21 attribute selectors not dynamic for xml
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 26 00:34:40 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=25072
------- Comment #5 from kai at granus.net 2009-05-26 00:34 PDT -------
Hello Nikolas,
thanks for reviewing.
Ill do the changes and create a new patch (sorry for all the tabs).
Just a few questions and remarks:
> Does a 0ms timer work here, instead of forcing a 100ms wait? Timing dependant
> tests should be avoided, if possible.
Indeed it does, Ill change this - much better.
> You also want to add a pixel test result here.
Really? I dont mind, but the dumped render tree does include the background
color already. If desired, I can also change the test to display "FAIL" or
"PASS".
> An expert in that area like Hyatt or Maciej would need to review it.
Absolutely. Will this just happen, or do I have to take some action to make it
happen?
> Your name is also misspelled :-)
Not if the file is interpreted as utf-8. Were in the unicode age, arent we?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list