[Webkit-unassigned] [Bug 26010] Serialize calls to WebInspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26010


pfeldman at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30652|0                           |1
        is obsolete|                            |




------- Comment #4 from pfeldman at chromium.org  2009-05-25 13:32 PDT -------
Created an attachment (id=30659)
 --> (https://bugs.webkit.org/attachment.cgi?id=30659&action=view)
patch

(In reply to comment #2)
> (From update of attachment 30652 [review])
> > +    overrideFrontendObject(m_scriptState, webInspectorObj);
> 
> I think "proxy" is a better term for this than "override".
> 
> Maybe frontendProxyObject?
> 

Renamed to setFrontendProxyObject

> > +WebInspector.dispatch = function() {
> > +  var methodName = arguments[0];
> > +  var parameters = Array.prototype.slice.call(arguments, 1);
> > +  WebInspector[methodName].apply(this, parameters);
> > +}
> 
> Please use 4 spaces for indenting.
> 

Done. Sorry about that - old habit.

> r- for that. Otherwise r+.
> 

(In reply to comment #3)
> (From update of attachment 30652 [review])
> > +ScriptFunctionCall* InspectorFrontend::newFunctionCall(const String& functionName)
> > +{
> > +    ScriptFunctionCall* function = new ScriptFunctionCall(m_scriptState, m_webInspector, "dispatch");
> > +    function->appendArgument(functionName);
> > +    return function;
> > +}
> 
> This would be an ideal place to use PassOwnPtr rather than a raw pointer, to
> indicate that ownership of an object is being transferred out of the function.
> 

Done.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.