[Webkit-unassigned] [Bug 26010] Serialize calls to WebInspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 25 10:55:30 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=26010


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30652|review?                     |review-
               Flag|                            |




------- Comment #2 from timothy at hatcher.name  2009-05-25 10:55 PDT -------
(From update of attachment 30652)
> +    overrideFrontendObject(m_scriptState, webInspectorObj);

I think "proxy" is a better term for this than "override".

Maybe frontendProxyObject?

> +WebInspector.dispatch = function() {
> +  var methodName = arguments[0];
> +  var parameters = Array.prototype.slice.call(arguments, 1);
> +  WebInspector[methodName].apply(this, parameters);
> +}

Please use 4 spaces for indenting.

r- for that. Otherwise r+.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list