[Webkit-unassigned] [Bug 25756] Explicit guards for ENABLE_GEOLOCATION

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 24 05:23:47 PDT 2009


------- Comment #9 from ddkilzer at webkit.org  2009-05-24 05:23 PDT -------
Per Maciej's feedback in
<https://lists.webkit.org/pipermail/webkit-dev/2009-May/007850.html>, he
prefers adding #ifdefs to files.

If this patch is landed again, these additional changes need to be made:

- The Geolocation-related export in WebCore/WebCore.base.exp needs to be put
into its own file (WebCore/WebCore.Geolocation.exp).
- WebCore/DerivedSources.make needs to be updated to append
WebCore.Geolocation.exp to WEBCORE_EXPORT_DEPENDENCIES (see examples for
WebCore.NPAPI.exp or WebCore.JNI.exp).
- A few files in WebKit/mac will need #if ENABLE(GEOLOCATION)/#endif guards

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list