[Webkit-unassigned] [Bug 25756] Explicit guards for ENABLE_GEOLOCATION

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 23 09:15:43 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25756


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org,
                   |                            |darin at apple.com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #6 from ddkilzer at webkit.org  2009-05-23 09:15 PDT -------
I'm backing out this change.   This broke all of the Mac builds:

http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/1322
http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/1555
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/1548

Also the Geolocation implementation was designed such that if you don't want
Geolocation, you should provide an empty implementation and not compile these
source files.

Please update the patch to do the above for your port rather than adding
ENABLE(GEOLOCATION) macro guards everywhere.  (It's possible that some
ENABLE(GEOLOCATION) guards will need to be added to get the desired result, but
not to entire files.)

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/bindings/js/JSCustomPositionCallback.cpp
        M       WebCore/bindings/js/JSCustomPositionCallback.h
        M       WebCore/bindings/js/JSCustomPositionErrorCallback.cpp
        M       WebCore/bindings/js/JSCustomPositionErrorCallback.h
        M       WebCore/bindings/js/JSGeolocationCustom.cpp
        M       WebCore/page/Geolocation.cpp
        M       WebCore/page/Geolocation.idl
        M       WebCore/page/Geoposition.cpp
        M       WebCore/page/Geoposition.h
        M       WebCore/page/Geoposition.idl
        M       WebCore/page/Navigator.cpp
        M       WebCore/page/PositionError.idl
        M       WebCore/platform/GeolocationService.cpp
Committed r44094

http://trac.webkit.org/changeset/44094


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list