[Webkit-unassigned] [Bug 25823] [Qt] Add API to generate a QUrl from a user string url

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 21:49:44 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25823


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30387|review?                     |review+
               Flag|                            |




------- Comment #4 from zecke at selfish.org  2009-05-22 21:49 PDT -------
(From update of attachment 30387)

> +    If that is not the case, an attempt is made to turn the string into a
> +    http:// or ftp:// URL. The latter in the case the string starts with
> +    'ftp'. The result is then passed through QUrl's tolerant parser, and
> +    in the case or success, a valid QUrl is returned, orelse a QUrl().

orelse??? space missing?



> +        QUrl url = view->guessUrlFromString(string);

my taste would say to use the static type QWebView::guessUrlFromString...
ignore that at your will..


are you sure that QWebView is the best place for that? If I have a QWebPage in
a graphics view item I still want to use the guessing and using QWebView might
not feel right. Do you think QWebView is the best place to put it? what about
QWebPage?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list