[Webkit-unassigned] [Bug 23642] [GTK] Drag and drop support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23642





------- Comment #14 from oliver at apple.com  2009-05-22 20:13 PDT -------
(From update of attachment 29786)

> +static CachedImage* getCachedImage(Element* element)
As far as I can tell this is copied directly from DragController, it seems a
better solution would be for this to be a shared function -- possibly on
Element, but i'm not sure.  I'd like hyatt's input.

> -void ClipboardGtk::writeURL(const KURL&, const String&, Frame*)
> +void ClipboardGtk::declareAndWriteDragImage(Element* element, const KURL& url, const String& label, Frame*)
I was just looking at the code for this on Mac and i'm wondering if it should
not be possible to move all this logic more directly into WebCore, but i don't
think that matters for this particular patch

>  
> -void ClipboardGtk::writeRange(Range*, Frame*)
> +void ClipboardGtk::writeURL(const KURL& url, const String& label, Frame*)
> +void ClipboardGtk::writeRange(Range* range, Frame* frame)

I do not believe it is right to arbitrarily write to the dragging pasteboard as
the Clipboard object is exposed to JS in some places where it is used (IIRC)
for non-dragging related clipboard interaction.

> diff --git a/WebCore/platform/gtk/DragImageGtk.cpp b/WebCore/platform/gtk/DragImageGtk.cpp
> index 4ddae3a..a8bc7d3 100644
> --- a/WebCore/platform/gtk/DragImageGtk.cpp
> +++ b/WebCore/platform/gtk/DragImageGtk.cpp
All the changes here look good.

> diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
Unfortunately the remainder of this patch is to heavily bound in gtk API
concepts for me to be able to review meaningfully


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.