[Webkit-unassigned] [Bug 20031] Implement ES 3.1 JSON object

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 19:42:04 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=20031


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30293|review?                     |review-
               Flag|                            |




------- Comment #30 from oliver at apple.com  2009-05-22 19:42 PDT -------
(From update of attachment 30293)
Okay, while in general i like the tests this patch does i'd like the testcases
to use our "standard" js testcase model then tryBackend becomes
shouldBe("JSON2.stringify(JSON2.parse(text))",
"JSON.stringify(JSON.parse(text))"), however this is optional (for now ;) )

I'd also like a few tests to cover large inputs, as well as use of the
replacement/reviver functions, specifically to test
 * which reviver functions get called; and
 * the order in which reviver functions are called

I'll r- this patch due to the additional testing that i'd like, but by and
large i like what's currently here, it just needs to be more complete.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list