[Webkit-unassigned] [Bug 15914] [GTK] Implement Unicode functionality using GLib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15914


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26793|review?                     |review+
               Flag|                            |




------- Comment #74 from gns at gnome.org  2009-05-22 10:56 PDT -------
(From update of attachment 26793)
> +        https://bugs.webkit.org/show_bug.cgi?id=15914
> +        [GTK] Implement Unicode functionality using GLib

I have gone through all the comments now, and have verified that most comments
have been addressed. I think the best way to move forward is to land the patch
in its current state, before it gets old enough that too much has changed, now
that you have made it smaller and self-contained. I have given it another pass,
and found only indentation problems, which I fixed (see UnicodeGLib.h for
reference, so that you can get it right for the next patches), and two missing
function implementations (including the one found by Mikkel), which I added. I
also fixed header inclusion on top of UnicodeGLib.h.

I have tested that the ICU backend keeps working, and passing tests. This,
along with the facts that icu keeps being the default, and that your patch
touches little cross platform code makes me believe that we're ready for
landing it now.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.