[Webkit-unassigned] [Bug 25961] wx port measures character widths incorrectly (Windows specific)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25961


kevino at theolliviers.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




------- Comment #3 from kevino at theolliviers.com  2009-05-22 10:11 PDT -------
Sorry, I know changing a review is unusual, but Eric didn't even give me an
opportunity to review the patch myself, and given all the questions he asked I
have to wonder why he didn't even give someone more qualified a chance to
review it. In fact, I had seen this patch even before it was posted, and this
is code that initially was going to go into wx, but now will probably be phased
out in the not-too-distant future. Until we do so, though, we need this as a
stopgap measure. In addition, we're still working on getting a complete testing
framework up and running for wx, so if we were to r- patches on those grounds,
we'd be unable to commit anything. Similarly, adding comments to every patch
because our testing framework isn't yet ready for action seems a bit silly. By
this rule, almost every wx patch ever committed should have this note, to the
point that we should probably write a script adding it. ;-)

wx is not in the same place, port-wise, as Win, Mac or Chromium and I'd
appreciate it if in the future, patch reviewers would either take that into
consideration before giving an r-, or preferably just leave port-specific
reviews to port reviewers. I assure you, I very rarely let a patch sit around
more than a few days in the queue without review!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.