[Webkit-unassigned] [Bug 25711] HTML5 Database becomes locked if a transaction is in progress when the page is refreshed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25711


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30483|review?                     |review-
               Flag|                            |




------- Comment #7 from eric at webkit.org  2009-05-22 06:59 PDT -------
(From update of attachment 30483)
Mostly style violations:
http://webkit.org/coding/coding-style.html

 622 int Database::busyHandler(void* p, int n) {
bad argument names, { goes on a new line

no { } needed:
4     while (n--) {
 625         millis += 1.2*millis;
 626     }
although we've been inconsistend w/ whiles.

Also spacing between 1.2 and millis (Which should be a full name, like
milliseconds)

We use constants instead of defines where possible:
 55 #define MAX_SQLITE_BUSY_WAIT_TIME 30000

Variable names:
 122     static int busyHandler(void* p, int n);

Tabs in the layout tests.

Otherwise this looks fine in general, but really you shoudl have Bradee look at
it for content once style is fixed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.