[Webkit-unassigned] [Bug 25566] REGRESSION: text inputs with "size" are often smaller than before, but sometimes bigger (originally noticed in bugs.webkit.org text fields)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25566


ojan at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|25958                       |
              nThis|                            |




------- Comment #13 from ojan at chromium.org  2009-05-22 02:44 PDT -------
I have a fix:
1. Windows uses a 13px default font for textareas and inputs. Mac uses 11px.
col/size width calculations depend on 13px metrics. We need a quirk for this in
RenderTextControl (i.e. pass 13 instead of 11 when the FontDescription is using
the default font size instead of an explicit size).
2. Explicitly set font-sizes for textareas and inputs will match if we use
rounded OS/2 avgCharWidth values.

Fonts that have a non-positive (invalid) OS/2 avgCharWidth value should use the
width of '0' in order to match Safari 3. I have filed a follow-up bug 25958 to
investigate matching IE in these cases. I have only seen these for Mac fonts
(which are not an IE-compat issue).

Also, maxCharWidth still needs to be investigated. This is bug 25581. This is
lower impact, however, as maxCharWidth has a fixed effect (~10px depending on
the font), whereas avgCharWidth has an effect proportional to the size/cols
value.

Sadly, I'm about to get on a plane to head off to vacation for one week. :( I
will not have internet access. I intend to post a patch to fix this as
described above on June 1st. If someone feels the urge to fix it before then,
feel free.

I'll address bugs 25581 and 25958 once this bug is fixed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.