[Webkit-unassigned] [Bug 16362] Incorrect implementation of 'ex' unit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16362





------- Comment #17 from mjs at apple.com  2009-05-21 21:54 PDT -------
(From update of attachment 21015)
1) The patch removes this comment and the code explained by it:

-        // Use the maximum of either width or height because "x" is nearly
square
-        // and web pages that foolishly use this metric for width will be laid
out
-        // poorly if we return an accurate height. Classic case is Times 13
point,
-        // which has an "x" that is 7x6 pixels.

Do you believe this is no longer necessary? If so, why not? Did you test what
other browsers do with Times 13 point? I think such a specific comment needs to
be addressed and rebutted if it no longer applies.

2) The change to the default style of radio buttons and checkboxes seems
unrelated. Is there any reason it needs to be included with this patch, rather
than making the change separately? Also, what is the reason for the html4.cc
change? It doesn't seem to be explained in the patch or in the bug.

r- for now but I will personally review this patch given satisfactory answers
to these questions, rather than waiting for Hyatt.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.