[Webkit-unassigned] [Bug 23430] Frame Refactor: Move methods from Frame to Editor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 18:32:56 PDT 2009


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #26862|review?                     |review+
               Flag|                            |

------- Comment #2 from eric at webkit.org  2009-05-21 18:32 PDT -------
(From update of attachment 26862)
So long as you're just moving code, this looks great.  I worry that this patch
is long-since rotten (that the methods you're moving may have changed).

It seems a little strange that selectedText() is on Editor instead of say
SelectionController, but it seems fine.

r=me, if you make sure the patch is updated to compile with TOT with all the
LayoutTests passing and that you're certain that the code you are moving is

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list