[Webkit-unassigned] [Bug 24903] Text files which have sub MIME types are treated as not displayable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24903





------- Comment #15 from beidson at apple.com  2009-05-21 17:06 PDT -------
This broke all layout tests - run them before landing patches!!!  =D

Darin had a comment:
"Besides "text/", you should remove all the "text/*" MIME types from
initializeSupportedNonImageMimeTypes because none of them do us any good. That
includes "text/vnd.wap.wml" as well as the others that are not inside an
ifdef."

This was incorrect.  In addition to answering the question "is this a supported
non image mimetype?", MIMETypeRegistry also has the role of delivering a
collection of all known non-image MIME types via the
::getSupportedNonImageMIMETypes() method.

That method is exposed to the WebKit layer of the various platforms who do
various things with it.  This completely hosed the Mac platform as it no longer
registered WebHTMLView as the view class for "text/html", since "text/html"
never showed up in the list of supported MIME types. 

The other half of the change - having isSupportedNonImageMIMEType() return true
if the passed in type starts with "text/" might be valid.  We might need
further changes to the design here such that we can do fuzzy matching of
subtypes.  But the full types we explicitly list in the registry must remaining
explicitly listed!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.