[Webkit-unassigned] [Bug 25922] setting event.dataTransfer.dropEffect = 'none' from ondragover breaks, but ondragenter works

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25922





------- Comment #3 from eric at webkit.org  2009-05-21 04:44 PDT -------
I think this may be a combination of two factors.
1.  We create a new Clipboard for every event:
DragOperation DragController::tryDHTMLDrag(DragData* dragData)
    RefPtr<Clipboard> clipboard = dragData->createClipboard(policy);
2.  We use DragOperationNone to indicate that a document won't handle a drag:
DragOperation DragController::dragEnteredOrUpdated(DragData* dragData)
        operation = tryDocumentDrag(dragData, m_dragDestinationAction);
        if (operation == DragOperationNone && (m_dragDestinationAction &
DragDestinationActionLoad))
            return operationForLoad(dragData);

tryDocumentDrag needs to return another parameter, which indicates if the
document handled the drag or not.

And I don't think we should be creating a new clipboard on every event.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.