[Webkit-unassigned] [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25415





------- Comment #15 from joanmarie.diggs at gmail.com  2009-05-20 18:16 PDT -------
(In reply to comment #12)
> Created an attachment (id=30465)
 --> (https://bugs.webkit.org/attachment.cgi?id=30465&action=view) [review]
> gettextv3.patch
> 
> OK, I think I've fixed all issues raised in the last comment (most of them were
> really special cases of the same bug: "Not taking into account being in the
> first or last word/sentence"). I've also fixed the crashers, which were due to
> not doing error checking properly in some cases.

In terms of testing, so far so good. Awesome!!

> LINE_{START,END} is still missing from the patch.

Understood. Having that is quite important, but I don't see it as a reason to
hold off committing what you've done so far.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.