[Webkit-unassigned] [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 07:32:13 PDT 2009


------- Comment #14 from xan.lopez at gmail.com  2009-05-20 07:32 PDT -------
(In reply to comment #13)
> (In reply to comment #12)
> > Created an attachment (id=30465)
 --> (https://bugs.webkit.org/attachment.cgi?id=30465&action=view) [review] [review]
> > gettextv3.patch
> > 
> > OK, I think I've fixed all issues raised in the last comment (most of them were
> > really special cases of the same bug: "Not taking into account being in the
> > first or last word/sentence"). I've also fixed the crashers, which were due to
> > not doing error checking properly in some cases.
> Hi Xan. Is it possible to split this patch into bite-sized chunks so it's
> easier to review? Thanks.

Well, I'm not sure. I mean, the bulk of it is the getTextHelper function, and
that can't be really splitted too much (I could do a first version only
supporting the CHAR boundary and then add everything else perhaps, but that's a
bit artificial), since the point of it is that it manages to implement 4
boundaries with the same code. Everything else are either little helper
functions for getTextHelper, the test file, or the actual hooking of the code
into the ATK API, which is trivial.

What are you having problems with?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list