[Webkit-unassigned] [Bug 25857] new dtoa.cpp strict-aliasing issues with gcc 4.4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25857





------- Comment #5 from craig.schlenter at gmail.com  2009-05-20 06:36 PDT -------
Excellent suggestion! Using the alternate Storeinc macro kills the strict
aliasing warnings completely for me.

There are some parentheses warnings which appear harmless. The
anonymous/uninitialized warning below appears to be technically correct but I
haven't looked at whether it matters in practice yet.

Here's the new compiler output:

( Line numbers are probably off by 1 as I added an extra line with the macro ) 

Compiling
/home/craig/chromium.git/src/sconsbuild/Release/obj/third_party/WebKit/JavaScriptCore/wtf/dtoa.os
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp: In
function 'void WTF::mult(WTF::BigInt&, const WTF::BigInt&)':
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:506:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:518:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp: In
function 'void WTF::diff(WTF::BigInt&, const WTF::BigInt&, const
WTF::BigInt&)':
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:737:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:744:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp: In
function 'int WTF::quorem(WTF::BigInt&, WTF::BigInt&)':
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:1745:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:1785:
warning: suggest parentheses around arithmetic in operand of '|'
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp: In
function 'void WTF::dtoa(char*, double, int, int*, int*, char**)':
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:294:
warning: '<anonymous>' may be used uninitialized in this function
/home/craig/chromium.git/src/third_party/WebKit/JavaScriptCore/wtf/dtoa.cpp:2136:
note: '<anonymous>' was declared here


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.