[Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23727





------- Comment #13 from levin at chromium.org  2009-05-20 00:40 PDT -------
fyi, since I was looking at this change due to the test break, I noticed some
style nits in the change:

In WebCore/css/CSSParser.cpp
    FInteger|FNonNeg 
 should be 
    FInteger | FNonNeg

    FTime|FInteger|FNonNeg
 same as above.

In WebCore/css/CSSStyleSelector.cpp

    EOverflow o = OMARQUEE;
 This variable appears unused.


   switch (primitiveValue->getIdent()) {
       case CSSValueLtr:
The case should align with the switch -- the statements in the case should be
indented.


WebCore/rendering/RenderMarquee.cpp
   if (m_totalLoops == 0)
should be
   if (!m_totalLoops)

Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.