[Webkit-unassigned] [Bug 23642] [GTK] Drag and drop support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23642


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28123|review?                     |review-
               Flag|                            |




------- Comment #13 from gns at gnome.org  2009-05-19 18:34 PDT -------
(From update of attachment 28123)
> +    if (image())
> +        deleteDragImage(image());
> +    setImage(0);

This seems to be wrong indeed. You would at least need to implement the
function for GTK+. I believe the best course of action is changing this,
though:

#elif PLATFORM(GTK)
    typedef void* DragImageRef;
#endif

I think you should turn this into:

typedef GOwnPtr<GdkPixbuf*> DragImageRef;

Then you would not need the deleteDragImage implementation and call at all. I
believe these changes could be part of this patch, since the drag clipboard
implementation doesn't touch other code, it wouldn't matter in terms of
bisecting. Sounds good?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.