[Webkit-unassigned] [Bug 25864] New: strict aliasing issues in WebCore/page/SecurityOriginHash.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25864

           Summary: strict aliasing issues in
                    WebCore/page/SecurityOriginHash.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: craig.schlenter at gmail.com


I've been compiling chromium with gcc 4.4 and I've had to use
-fno-strict-aliasing for webkit due to a couple of issues. The code in question
should be equivalent to that in WebKit itself. Here's one of the issues:

In file included from
/home/craig/chromium.git/src/third_party/WebKit/WebCore/storage/OriginQuotaManager.h:35,
                 from
/home/craig/chromium.git/src/third_party/WebKit/WebCore/storage/DatabaseTracker.cpp:40:
/home/craig/chromium.git/src/third_party/WebKit/WebCore/platform/text/StringImpl.h:
In static member function 'static unsigned int
WebCore::SecurityOriginHash::hash(WebCore::SecurityOrigin*)':
/home/craig/chromium.git/src/third_party/WebKit/WebCore/platform/text/StringImpl.h:210:
warning: dereferencing pointer 'data' does break strict-aliasing rules
/home/craig/chromium.git/src/third_party/WebKit/WebCore/page/SecurityOriginHash.h:46:
note: initialized from here
/home/craig/chromium.git/src/third_party/WebKit/WebCore/platform/text/StringImpl.h:213:
note: initialized from here
/home/craig/chromium.git/src/third_party/WebKit/WebCore/platform/text/StringImpl.h:211:
warning: dereferencing pointer '<anonymous>' does break strict-aliasing rules
/home/craig/chromium.git/src/third_party/WebKit/WebCore/platform/text/StringImpl.h:211:
note: initialized from here

I'm attaching a patch which seems to work for me but I have only tested it on
linux ... I don't know how other compilers will deal with the union
initialisation etc. etc.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.