[Webkit-unassigned] [Bug 25119] IME modifies the DOM before keydown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25119





------- Comment #24 from eric at webkit.org  2009-05-19 06:06 PDT -------
(From update of attachment 30464)
1 CONSOLE MESSAGE: line 77: TypeError: Result of expression 'keyDowns[current]'
[undefined] is not an object.

if (event.characters[0] == '\n') {
3     // Enter key is charCode 13.
4     if (event.characters[0] == String.fromCharCode(13)) {
and why is that clearer?
I figure \n is eaiser to read than fromCharCode(13)
WK style does not != null:
16         if (kotoeriState.compositionString != null) {
if (foo)
not if(foo != null)

Why do you call:
1862     keyDown->setDefaultHandled();
fro in  1857 void
EventHandler::dispatchInputMethodKeyDownEvent(PassRefPtr<KeyboardEvent>
keyDown)

I might have written:
 5311     if (parameters && parameters->event &&
!parameters->keyDownWasDispatched && parameters->shouldSaveCommand) {

to early return instead... but it's fine as is.

 5348         else if (hasKeypressCommand) {
probably needs a changelog comment.

If there ever was a need for a static function.. this copy/paste was it:
} else if ([character isEqualToString:@"escape"]) {
 469         const unichar ch = 0x1B;
 470         eventCharacter = [NSString stringWithCharacters:&ch length:1];


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.