[Webkit-unassigned] [Bug 25298] Ctrl + Right/Left arrow move forward/backward through document instead of right/left in RTL text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25298





------- Comment #7 from xji at chromium.org  2009-05-18 12:13 PDT -------
(In reply to comment #6)
> Created an attachment (id=30436)
 --> (https://bugs.webkit.org/attachment.cgi?id=30436&action=view) [review]
> Proposed fix for review
> 
> Modified code is present under 
> static bool executeMoveWordLeft(Frame* frame, Event*, EditorCommandSource,
> const String&)
> static bool executeMoveWordLeftAndModifySelection(Frame* frame, Event*,
> EditorCommandSource, const String&)
> static bool executeMoveWordRight(Frame* frame, Event*, EditorCommandSource,
> const String&)
> static bool executeMoveWordRightAndModifySelection(Frame* frame, Event*,
> EditorCommandSource, const String&)
> 

Hi Arvind,

Thanks for working on this. 

1. I thought you were using whether the renderer()->style()->direction() == RTL
to toggle to move left/right, then, I think my previous comments apply.

2. By using renderer->containsReversedText(), seems it works fine for the test
case. But it breaks the LTR text containing mixed text. 
I only tried the changed executeMoveWordLeft().
Given an example: 
<div contenteditable> 
abc אבג xyz דהו def
</div> 
ctrl+left-arrow works fine originally, but not with the fix. The fix moves the
cursor to right visually.

3. I think you probably do not need to change the 2 modify selection functions:
static bool executeMoveWordLeftAndModifySelection(Frame* frame, Event*,
EditorCommandSource, const String&)
static bool executeMoveWordRightAndModifySelection(Frame* frame, Event*,
EditorCommandSource, const String&)

They are corresponding to shift-ctrl-arrow, which follows logical order. and
should work fine after the fix of issue 24303
https://bugs.webkit.org/show_bug.cgi?id=24303

4. I guess  you are just uploading the patch for opinions, not for real review.
You probably know that for real review, you need to follow the guideline in
http://webkit.org/coding/contributing.html


Thanks,
Xiaomei


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.