[Webkit-unassigned] [Bug 25119] IME modifies the DOM before keydown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25119


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30435|review?                     |review-
               Flag|                            |




------- Comment #16 from eric at webkit.org  2009-05-17 23:20 PDT -------
(From update of attachment 30435)
A couple style nits:

 1427 void Editor::applyIMECommand(IMECommand* command) {

     IMECommand(const String& confirmedText)
 63     : text(confirmedText)
 64     , isConfirmationCommand(true) {}
(indent and {} should be on new lines)

No arg name needed:
 281     void applyIMECommand(IMECommand* command);


 34 </body>
 35 </html>
036 \ No newline at end of file


     // If there's a key event, stow away the IME command to be processed in
 5717     // EventHandler::keyEvent after the keydown has been fired.
 5718     if (parameters && parameters->event)
 5719         parameters->event->setIMECommand(command);
 5720     else
 5721         coreFrame->editor()->applyIMECommand(command);

Could go into a static function in the file instead of copy/paste.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.