[Webkit-unassigned] [Bug 25298] Ctrl + Right/Left arrow move forward/backward through document instead of right/left in RTL text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25298





------- Comment #5 from arvind.mookhaiyapillai at teleca.com  2009-05-17 22:25 PDT -------
(In reply to comment #4)
> (In reply to comment #3)
> > Hi,
> > I am analysing this bug and found a probable solution.
> > Kindly let me know the way I am planning to fix this bug is correct.
> > In editorcommand.cpp file functions executeMoveWordLeft() or
> > executeMoveWordRight() are used to create the fucntionality.Here I check for
> > the direction of the text and if the direction is RTL I reverse the direction
> > that is sent to frame->selection()->modify() function.
> > 
> 
> I doubt it works.
> The problem with current implementation is that ctrl+right/left arrow follows
> logical order. The correct behavior should be following visual order.
> 
> Seems that your fix assumes that visual order is the reverse of logical order
> in RTL, which might not be true.
> 
> Considering the following test cases:
> The logical order of a string is "abc def HIJ", in which "HIJ" are Hebrew
> characters.
> The visual order would be "JIH abc def", when cursor is within "abc", press
> ctrl+right arrow twice should move cursor to the end of "abc", then to the end
> of 'def'.
> 

Hi  Xiaomei Ji,
Thanks for your valuable suggestion.I checked the fix against the test case 
> Considering the following test cases:
> The logical order of a string is "abc def HIJ", in which "HIJ" are Hebrew
> characters.
> The visual order would be "JIH abc def", when cursor is within "abc", press
> ctrl+right arrow twice should move cursor to the end of "abc", then to the end
> of 'def'.

It seems to work fine. I have attached the fix that I had proposed. Kindly
review it and let me know your comments about it if you still feel there is
something wrong in the way I am trying to fix it. 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.