[Webkit-unassigned] [Bug 25822] DOM normalize does not remove empty text node between element nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25822


kai at granus.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30400|0                           |1
        is obsolete|                            |
  Attachment #30421|                            |review?
               Flag|                            |




------- Comment #8 from kai at granus.net  2009-05-17 06:54 PDT -------
Created an attachment (id=30421)
 --> (https://bugs.webkit.org/attachment.cgi?id=30421&action=view)
Patch with more thorough set of test cases

I extended the test case to (hopefully) test the full range of the normalize()
functionality. To express this, I renamed it to "normalize.html". The test
lives inside "dom", therefore I consider the term "normalize" well defined.
Please advice if a longer name is necessary.

Having these tests and after learning that document->textNodesMerged() does
adjust DOMRanges to the changed text nodes and nothing more, I changed the code
of Node::normalize() a little more to make it more concise and less historic.

Concerning rationale of the old code, I checked the ChangeLogs and found the
entry about the addition of the "single empty text node child" case. It is
indeed rather inexpressively, just stating the addition of this case.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.