[Webkit-unassigned] [Bug 25809] decorations __declspec(dlimport) and __declspec(dlexport) break linking on win32 with mingw

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 17 01:37:37 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25809





------- Comment #6 from jmalonzo at gmail.com  2009-05-17 01:37 PDT -------
(From update of attachment 30379)
> Index: JavaScriptCore/config.h
> ===================================================================
> --- JavaScriptCore/config.h	(revision 43762)
> +++ JavaScriptCore/config.h	(working copy)
> @@ -25,7 +25,7 @@
>  
>  #include <wtf/Platform.h>
>  
> -#if PLATFORM(WIN_OS) && !defined(BUILDING_WX__)
> +#if PLATFORM(WIN_OS) && !defined(BUILDING_WX__) && !COMPILER(GCC)
>  #if defined(BUILDING_JavaScriptCore) || defined(BUILDING_WTF)

Is there a reason why you're not using COMPILER(MINGW32) here?

Since this is specific to mingw, I think we should use COMPILER(MINGW32) here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list